[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 12/13] xen/iommu: smmu: Add Xen specific code to be able to use the driver

Hello Manish,

On 02/02/2015 18:55, Manish wrote:
A general comment,

Please avoid top post.

master->of_node is used as a unique value in the rb_tree. In case of
pci_passthrough devices are enumerated and not present in device tree,
so I would have to remove the rb_tree and replace with a linked list.

Clearly no. There is no big change necessary in the code. Think that Linux is able to handle PCI with master->of_node. So why Xen has to be different?

In case of PCI, master is attached to a root bus. Every root buses are described in the device tree so they are associated to a device node.

I have added few TODOs (just search TODO) in the code where you should plumb to support PCI. Any change outside is by default wrong.

The TODOs are:
* dev_get_dev_node: you have to find the root bus and return the device node. * arm_smmu_add_device: You have to get the stream IDs associate to it and store it in the PCI device IOMMU data.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.