Re: [Xen-devel] [PATCH v2 15/15] xen/arm: gic-v3: Update some comments in the code

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2015-01-29 at 18:25 +0000, Julien Grall wrote:
>     - Drop wrong comment about the default stride. It's not always 2 * SZ_64K

What other defaults are possible and under what circumstances?

>     - Explain why SZ_64K * 2
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 
> ---
>     Changes in v2:
>         - Patch added
> ---
>  xen/arch/arm/gic-v3.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
> index 1b7ddb3..9035e3b 100644
> --- a/xen/arch/arm/gic-v3.c
> +++ b/xen/arch/arm/gic-v3.c
> @@ -638,7 +638,7 @@ static int __init gicv3_populate_rdist(void)
>                  ptr += gicv3.rdist_stride;
>              else
>              {
> -                ptr += SZ_64K * 2;
> +                ptr += SZ_64K * 2; /* Skip RD_base + SGI_base */
>                  if ( typer & GICR_TYPER_VLPIS )
>                      ptr += SZ_64K * 2; /* Skip VLPI_base + reserved page */
>              }
> @@ -1238,7 +1238,6 @@ static int __init gicv3_init(struct dt_device_node 
> *node, const void *data)
>          rdist_regs[i].size = rdist_size;
>      }
>  
> -    /* If stride is not set in dt. Set default to 2 * SZ_64K */
>      if ( !dt_property_read_u32(node, "redistributor-stride", 
> &gicv3.rdist_stride) )
>          gicv3.rdist_stride = 0;
>  



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel