Re: [Xen-devel] [PATCH v2 18/29] Ovmf/Xen: move XenBusDxe hypercall code to separate library

[Laszlo Ersek <lersek@xxxxxxxxxx>]

one important comment

On 01/26/15 20:03, Ard Biesheuvel wrote:
> This moves all of the Xen hypercall code that was private to XenBusDxe
> to a new library class XenHypercallLib. This will allow us to reimplement
> it for ARM, and to export the Xen hypercall functionality to other parts
> of the code, such as a Xen console SerialPortLib driver.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> ---
>  OvmfPkg/{XenBusDxe/XenHypercall.h => Include/Library/XenHypercallLib.h} | 16 
> ++-------------
>  OvmfPkg/{XenBusDxe => Library/XenHypercallLib}/Ia32/hypercall.nasm      |  0
>  OvmfPkg/{XenBusDxe => Library/XenHypercallLib}/X64/hypercall.nasm       |  0
>  OvmfPkg/{XenBusDxe => Library/XenHypercallLib}/XenHypercall.c           | 37 
> ++--------------------------------
>  OvmfPkg/Library/XenHypercallLib/XenHypercallIntel.c                     | 77 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  OvmfPkg/Library/XenHypercallLib/XenHypercallLibIntel.inf                | 52 
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  OvmfPkg/OvmfPkg.dec                                                     |  4 
> ++++
>  OvmfPkg/OvmfPkgIa32.dsc                                                 |  1 
> +
>  OvmfPkg/OvmfPkgIa32X64.dsc                                              |  1 
> +
>  OvmfPkg/OvmfPkgX64.dsc                                                  |  1 
> +
>  OvmfPkg/XenBusDxe/EventChannel.c                                        |  3 
> ++-
>  OvmfPkg/XenBusDxe/GrantTable.c                                          |  2 
> +-
>  OvmfPkg/XenBusDxe/XenBusDxe.c                                           |  9 
> +--------
>  OvmfPkg/XenBusDxe/XenBusDxe.inf                                         | 11 
> +----------
>  OvmfPkg/XenBusDxe/XenStore.c                                            |  2 
> +-
>  15 files changed, 146 insertions(+), 70 deletions(-)
> 
> diff --git a/OvmfPkg/XenBusDxe/XenHypercall.h 
> b/OvmfPkg/Include/Library/XenHypercallLib.h
> similarity index 82%
> rename from OvmfPkg/XenBusDxe/XenHypercall.h
> rename to OvmfPkg/Include/Library/XenHypercallLib.h
> index 9d49e33eb5af..dc2c5424683c 100644
> --- a/OvmfPkg/XenBusDxe/XenHypercall.h
> +++ b/OvmfPkg/Include/Library/XenHypercallLib.h
> @@ -13,8 +13,8 @@
>  
>  **/
>  
> -#ifndef __XENBUS_DXE_HYPERCALL_H__
> -#define __XENBUS_DXE_HYPERCALL_H__
> +#ifndef __XEN_HYPERCALL_LIB_H_
> +#define __XEN_HYPERCALL_LIB_H_

I guess if you lead it with "__", then you should also trail it with
"__". :)

Other than that, it looks good to me.

Reviewed-by: Laszlo Ersek <lersek@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel