[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 6/7] build system: stubdom targets now depends on mini-os target

On Mon, 2015-02-02 at 12:59 +0000, Wei Liu wrote:
> Provide mini-os url and revision in Config.mk
> Introduce Makefile.mini-os which contains mini-os specific targets.

I'm not sure it has enough content to warrant that, those two targets
could easily be inlined.

> +ifeq ($(wildcard $(MINI_OS)/Config.mk),)
> +$(error Please run `make mini-os-dir' in top-level directory)
> +endif

This makes me think that maybe my earlier suggestion to move the clone
under stubdom/ might be better done right away.

In fact, that would avoid the need to play tricks with renaming extras/
too, since you could build both for a commit.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.