[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 0/6] xen/arm: Move in/out code to/from init section

On 02/02/15 13:12, Jan Beulich wrote:
> This example in particular makes clear that looking at just the
> declaration is insufficient in certain cases.Whoever is looking
> for specific properties of a functions needs to know which ones
> (s)he cares about, and then look in the appropriate place.

__init is common attribute that should be looking by anyone calling a
function. You can't guess about it.

> Unless a rule gets put in place overriding my personal opinion on
this, I'm
> not going to ack or otherwise accept needless code duplication.

It may be needless for the compiler but not for some of the developers.

> If the ARM maintainers feel differently, so be it.

If you look a the ARM headers (asm-arm) we use __init on the prototype.
But x86 and common code is not using it.

The point of this discussion is there is no written rules... It happened
because an x86 maintainer shout about inconsistency on the ARM headers
on my first patch.

If this is going to be the standard on every headers, this should be
written somewhere and not letting the developer guess how the maintainer
will feel about it.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.