Re: [Xen-devel] [PATCH v2 1/5] x86/shadow: tidy up fragmentary page lists in multi?page shadows

[Tim Deegan <tim@xxxxxxx>]

At 11:47 +0000 on 02 Feb (1422874047), Jan Beulich wrote:
> >>> On 02.02.15 at 12:43, <andrew.cooper3@xxxxxxxxxx> wrote:
> > On 02/02/15 11:18, Jan Beulich wrote:
> >> --- a/xen/arch/x86/mm/shadow/common.c
> >> +++ b/xen/arch/x86/mm/shadow/common.c
> >> @@ -1196,6 +1196,26 @@ int shadow_cmpxchg_guest_entry(struct vc
> >>   * the free pool.
> >>   */
> >>  
> >> +const u32 sh_type_to_size[] = {
> > 
> > u8 instead?  The maximum value held is 4.
> 
> Good point, but it was u32 before, so I'll leave it to Tim to decide.

Yes, u8 would be better.

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel