Re: [Xen-devel] [PATCH v3 06/13] xen/arm: Introduce a generic way to describe device

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 30.01.15 at 19:49, <julien.grall@xxxxxxxxxx> wrote:
> Currently, Xen is supporting PCI and Platform device (based on Device Tree).
> 
> While Xen only supports Platform device on ARM, Xen will gain support of
> PCI soon.
> 
> Some drivers, such as IOMMU drivers, may handle PCI and platform device in
> the same way. Only few lines of code differs.
> 
> Rather than requesting to provide 2 set of functions (one for PCI and
> one for platform device), introduce a generic structure "device" which
> is embedded in each specialized device.
> 
> As x86 only supports PCI, introduce a new type device_t which will be an
> alias to pci_dev for this architecture. It will avoid to add a new field
> for this place.
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>

Non-ARM-specific parts:
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
albeit this

> --- a/xen/include/xen/iommu.h
> +++ b/xen/include/xen/iommu.h
> @@ -25,6 +25,7 @@
>  #include <xen/pci.h>
>  #include <public/hvm/ioreq.h>
>  #include <public/domctl.h>
> +#include <asm/device.h>

seems unnecessary as xen/pci.h in already being included here.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel