Re: [Xen-devel] [PATCH OSSTEST v2 12/18] Toolstack: Refactor migration support.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2015-01-22 at 15:19 +0000, Ian Campbell wrote:
> On Thu, 2015-01-22 at 15:17 +0000, Ian Jackson wrote:
> > Ian Campbell writes ("Re: [PATCH OSSTEST v2 12/18] Toolstack: Refactor 
> > migration support."):
> > > On Tue, 2015-01-20 at 18:38 +0000, Ian Jackson wrote:
> > > > Again, I think you should pass the $dho rather than the name.  In
> > > > general it's better to pass the hash object to these kind of methods.
> > > 
> > > For ts-guest-localmigrate is there a cunning stunt you would recommend
> > > to generate a $dho with ->{Name} == "localhost"?
> > > 
> > > Or perhaps:
> > >         $dho ? $dho->{Name} : "localhost"
> > > ? (i.e. $dho==undef => localhost)
> > 
> > That would do, although it's a big magic.
> > 
> > Magic in a different way would be:
> > 
> >   ->migrate($ts, $gho, { %$dho, Name => 'localhost' }, $timeout)
> 
> In the caller? There is no $dho in that case. But I think maybe you
> meant $gho? (i.e. this is supposed to produce a copy of $gho with a
> different name)

Actually in this context I think $ho is what was wanted, that's what I
went with.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel