Re: [Xen-devel] [PATCH OSSTEST v2 12/18] Toolstack: Refactor migration support.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH OSSTEST v2 12/18] Toolstack: Refactor migration 
support."):
> Note that since the previous patch arranges for
> ts-migration-support-check to continue to fail for libvirt the libvirt
> code is not actually called yet (and will die if it is). This patch is
> mainly included to reduce the number of users of
> toolstack()->{Command} closer to zero.
...
> +sub migrate ($$$$) {
> +    my ($self,$gho,$dst,$to) = @_;
> +    my $ho = $self->{Host};
> +    my $gn = $gho->{Name};
> +    target_cmd_root($ho,
> +                 $self->{Command}." migrate $gn $dst",
> +                 $to);
> +}

Again, I think you should pass the $dho rather than the name.  In
general it's better to pass the hash object to these kind of methods.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel