[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] libxl memory leaks when Xen is compiled with XSM

Correctly CC'ing xen-devel as well this time


On 19/12/14 14:31, Andrew Cooper wrote:
> Hello,
> Coverity has identified a large number of memory leaks in libxl, because
> of the use of libxl_domain_info() without an init/dispose for the
> libxl_dominfo object.
> If XSM is active, this leaks the ssid_label string, and in almost all
> cases, from the successful completion of the library function in question.
> Most of the issues can be fixed with the correct use of
> init()/dispose(), but libxl_wait_for_memory_target() is a little more
> interesting.
> Strictly speaking, I think I would need to fix it with a
> dispose();init() pair immediately before the call to
> libxl_domain_info().  However, this feels like overkill.  As only the
> memory information is needed, would it be appropriate to downgrade to an
> xc_domain_getinfo() instead, forgoing the memory allocation and
> extraneous hypercalls?
> ~Andrew

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.