Re: [Xen-devel] [PATCH OSSTEST v3 04/11] overlay: update overlay/etc/grub.d/20_linux_xen

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Dec 10, 2014 at 12:54:05PM +0000, Ian Campbell wrote:
> On Tue, 2014-10-14 at 22:50 +0100, Wei Liu wrote:
> > This file was created to work around Debian bug #633127.
> > 
> > According to Debian bug tracker [0], this bug is fixed in Wheezy. As
> > we're now using Wheezy in OSSTest we can safely remove this overlay
> > file.
> > 
> > Also add a note to reference #633127 above grub2 setup function, in case
> > someone trips over #633127.
> > 
> > As we're now using Wheezy in production, update this file to Wheezy's
> > version and take care of Debian bug #690538 and GRUB bug #43420.
> 
> When reference bugs it would be useful to include the bug title here so
> the reader doesn't have to go and look it up.
> 

OK.

> #690538 relates to providing an option to remove the submenus. Please
> can the changelog explain why that is relevant to us.
> 

Because somebody else thought not making submenu optional is a bug. So
do I.

> Did you fix it by removing/reverting the submenu support altogether, as
> opposed to e.g. importing the patch from Eric Fischer in the bug report?
> I don't see stuff which I'd expect if you had applied the patch. I think
> it would be worth spelling out in a bit more detail what the changes
> you've made to the baseline for each bug were.
> 

I fixed this by supplying a 20_linux_xen extracted from wheezy with
submenu generation removed (2 lines). This is how we dealt with other
grub bugs.

> I suppose constructing overlay/etc/grub.d/20_linux_xen from a baseline
> unmodified version (checked in, not retrieved from the host) and a
> mini-patch-series (also checked in) on the fly is over complexifying
> things?
> 

Certainly more complex than a single file solution. At the very least
new infrastructure to apply patches for overlay files is needed.

Wei.

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel