Re: [Xen-devel] [PATCH OSSTEST v3 10/11] ts-xen-install: install Xen with XSM support if requested

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Dec 10, 2014 at 01:15:13PM +0000, Ian Campbell wrote:
> On Tue, 2014-10-14 at 22:50 +0100, Wei Liu wrote:
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > ---
> >  ts-xen-install |    4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/ts-xen-install b/ts-xen-install
> > index 4d34d1f..2e2fcbc 100755
> > --- a/ts-xen-install
> > +++ b/ts-xen-install
> > @@ -46,6 +46,8 @@ if (@ARGV and $ARGV[0] eq '--check') {
> >  
> >  our $ho;
> >  
> > +my $enable_xsm = $r{enable_xsm} =~ m/y/ ? 1 : 0;
> > +
> >  my %distpath;
> >  
> >  sub packages () {
> > @@ -171,7 +173,7 @@ sub setupboot () {
> >      }
> >  
> >      my $want_kernver = get_runvar('kernel_ver',$r{'kernbuildjob'});
> > -    debian_boot_setup($ho, $want_kernver, $xenhopt, \%distpath, \@hooks);
> > +    debian_boot_setup($ho, $want_kernver, $enable_xsm, $xenhopt, 
> > \%distpath, \@hooks);
> 
> Doesn't this have to be in the same patch as the one which adds the new
> parameter in the function declaration? Or at least that patch needs to
> hardcode a false until now.
> 

Yes, I noticed this after I sent this series.  I will squash this one
into previous commit.

Wei.

> (not sure we care much about bisectability in osstest, Ian?)
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel