[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 13/19] hvmloader: construct SRAT
>>> On 09.12.14 at 19:06, <wei.liu2@xxxxxxxxxx> wrote: > On Tue, Dec 09, 2014 at 04:53:40PM +0000, Jan Beulich wrote: >> >>> On 01.12.14 at 16:33, <wei.liu2@xxxxxxxxxx> wrote: >> > + memset(memory, 0, sizeof(*memory)); >> > + memory->type = ACPI_MEMORY_AFFINITY; >> > + memory->length = sizeof(*memory); >> > + memory->domain = vmemrange[i].nid; >> > + memory->flags = ACPI_MEM_AFFIN_ENABLED; >> > + memory->base_address = vmemrange[i].start; >> > + memory->mem_length = mem; >> > + memory++; >> > + } >> > + >> > + srat->header.length = size; >> >> Mind checking size == memory - p here? >> > > Why? There doesn't seem to be anything that would cause memory -p != > size in between during runtime. Except for that original calculation being wrong - that's what I would mean such a check to verify. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |