Re: [Xen-devel] [PATCH v2 12/19] hvmloader: retrieve vNUMA information from hypervisor

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.12.14 at 18:52, <wei.liu2@xxxxxxxxxx> wrote:
> On Tue, Dec 09, 2014 at 04:46:22PM +0000, Jan Beulich wrote:
>> >>> On 01.12.14 at 16:33, <wei.liu2@xxxxxxxxxx> wrote:
>> > + */
>> > +
>> > +#ifndef __HVMLOADER_VNUMA_H__
>> > +#define __HVMLOADER_VNUMA_H__
>> > +
>> > +#include <xen/memory.h>
>> > +
>> > +#define MAX_VNODES     64
>> > +#define MAX_VDISTANCE  (MAX_VNODES * MAX_VNODES)
>> > +#define MAX_VMEMRANGES (MAX_VNODES * 2)
>> 
>> These look arbitrary - please add a (brief) comment giving some
>> rationale so that people needing to change them know eventual
>> consequences. Would it perhaps make sense to derive
>> MAX_VNODES from HVM_MAX_VCPUS? Additionally I think the
> 
> I don't think these two have very strong connection though.
> 
> And I remember you saying HVM_MAX_VCPUS will be removed.

Removed? I recall myself saying increased...

>> code wouldn't become much more difficult if you didn't build in
>> static upper limits.
>> 
> 
> Yes I can make two hypercalls. First one to retrieve the number of nodes
> / vmemranges configured, allocate memory then fill in those arrays with
> second hypercall.

That'd be great, as it would eliminate the point above at once.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel