Re: [Xen-devel] [PATCH 2/4] sysctl/libxl: Add interface for returning IO topology data

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Dec 02, 2014 at 04:34:08PM -0500, Boris Ostrovsky wrote:
[...]
>  void libxl_cputopology_list_free(libxl_cputopology *, int nb_cpu);
>  
> +#define LIBXL_TOPOLOGY_INVALID_ENTRY (~(uint32_t)0)
> +libxl_topology *libxl_get_topology(libxl_ctx *ctx);
> +void libxl_topology_free(libxl_topology *);
> +
>  #define LIBXL_NUMAINFO_INVALID_ENTRY (~(uint32_t)0)
>  libxl_numainfo *libxl_get_numainfo(libxl_ctx *ctx, int *nr);
>  void libxl_numainfo_list_free(libxl_numainfo *, int nr);
> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> index f7fc695..673b273 100644
> --- a/tools/libxl/libxl_types.idl
> +++ b/tools/libxl/libxl_types.idl
> @@ -642,6 +642,18 @@ libxl_cputopology = Struct("cputopology", [
>      ("node", uint32),
>      ], dir=DIR_OUT)
>  
> +libxl_iotopology = Struct("iotopology", [
> +    ("seg", uint16),
> +    ("bus", uint8),
> +    ("devfn", uint8),
> +    ("node", uint32),
> +    ], dir=DIR_OUT)
> +
> +libxl_topology = Struct("topology", [
> +    ("cpu", Array(libxl_cputopology, "cpu_num")),
> +    ("dev", Array(libxl_iotopology, "dev_num")),
> +    ], dir=DIR_OUT)

Use "num_cpu" and "num_dev" please.

I think you also need to add a LIBXL_HAVE_$FOO in libxl.h. 

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel