Re: [Xen-devel] [PATCH for-4.5 1/2] xen/domctl: Fix getdomaininfo() of a domain without vcpus

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.10.14 at 18:21, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/common/domctl.c
> +++ b/xen/common/domctl.c
> @@ -156,6 +156,7 @@ void getdomaininfo(struct domain *d, struct 
> xen_domctl_getdomaininfo *info)
>      struct vcpu_runstate_info runstate;
>      
>      info->domain = d->domain_id;
> +    info->max_vcpu_id = XEN_INVALID_MAX_VCPU_ID;
>      info->nr_online_vcpus = 0;
>      info->ssidref = 0;

Afaict this will convert the so far random allocation failure in the
tool stack to a guaranteed one. Hence I think that despite them
touching hypervisor and tools, the patches should be folded to
not cause an apparent regression between applying the first
and second to people who are lucky in not hitting the allocation
failure right now.

In any event the hypervisor side is
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel