Re: [Xen-devel] [PATCH for-4.5] tools/libxl: Fix building against libxl for LIBXL_API_VERSION < 0x040500

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-10-17 at 15:19 +0100, Andrew Cooper wrote:
> On 17/10/14 12:08, Ian Jackson wrote:
> > Ian Jackson writes ("Re: [PATCH for-4.5] tools/libxl: Fix building against 
> > libxl for LIBXL_API_VERSION < 0x040500"):
> >> Andrew Cooper writes ("Re: [PATCH for-4.5] tools/libxl: Fix building 
> >> against libxl for LIBXL_API_VERSION < 0x040500"):
> >>> On 17/10/14 12:00, Ian Jackson wrote:
> >>>> I think this was intended to read
> >>>>   #define libxl_uuid_copy(dst, src) libxl_uuid_copy(NULL, dst, src)
> >>>> but should in fact read
> >>>>   #define libxl_uuid_copy(dst, src) libxl_uuid_copy(NULL, (dst), (src))
> > Having checked the rules, for C++ this might conceivably have to be
> >     #define libxl_uuid_copy(dst, src) (libxl_uuid_copy(NULL, (dst), (src)))
> >
> > Ian.
> 
> Fundamentally, I am not really fussed how this is fixed, although I have
> confirmed my patch fixes the libvirt build in the XenServer branch I am
> attempting to test Xen-4.5 under.

Ian, are you happy with that or do you want to (ask Andy to) resubmit
with the #define?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel