Re: [Xen-devel] [PATCH for-4.5] tools/libxl: Fix building against libxl for LIBXL_API_VERSION < 0x040500

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Andrew Cooper writes ("[PATCH for-4.5] tools/libxl: Fix building against libxl 
for LIBXL_API_VERSION < 0x040500"):
> c/s 6276f66ebe "libxl: libxl_uuid_copy now takes a ctx argument" introduces
> API compatibiltiy for libxl_uuid_copy() which sadly is not valid C.  Fix it.
...
>  #if defined(LIBXL_API_VERSION) && LIBXL_API_VERSION < 0x040500
> -void libxl_uuid_copy(dst, src) libxl_uuid_copy(NULL, dst, src)

I think this was intended to read
  #define libxl_uuid_copy(dst, src) libxl_uuid_copy(NULL, dst, src)
but should in fact read
  #define libxl_uuid_copy(dst, src) libxl_uuid_copy(NULL, (dst), (src))

I don't understand why you want to introduce a function as well as a
macro.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel