Re: [Xen-devel] [PATCH v8 1/8] xen: introduce gnttab_max_frames and gnttab_max_maptrack_frames command line options

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.10.14 at 11:48, <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> Changes in v8:
> - remove unused #include;
> - set max_nr_grant_frames as __initdata;
> - set max_grant_frames and max_maptrack_frames as __read_mostly;
> - respent coding style for comments;

Not sure what "respent" here means, but ...

> --- a/xen/common/grant_table.c
> +++ b/xen/common/grant_table.c
> @@ -40,16 +40,25 @@
>  #include <xsm/xsm.h>
>  #include <asm/flushtlb.h>
>  
> -#ifndef max_nr_grant_frames
> -unsigned int max_nr_grant_frames = DEFAULT_MAX_NR_GRANT_FRAMES;
> +/* this option is deprecated, use gnttab_max_frames and
> +   gnttab_max_maptrack_frames instead */

... this comment is still malformed.

> @@ -2930,6 +2934,22 @@ static struct keyhandler 
> gnttab_usage_print_all_keyhandler = {
>  
>  static int __init gnttab_usage_init(void)
>  {
> +    if ( max_nr_grant_frames )
> +    {
> +        printk(XENLOG_WARNING
> +               "gnttab_max_nr_frames is deprecated, use gnttab_max_frames 
> instead\n");
> +        if ( !max_grant_frames )
> +            max_grant_frames = max_nr_grant_frames;
> +        if ( !max_maptrack_frames )
> +            max_maptrack_frames = max_nr_grant_frames * 8;

Did it not occur to you to express the 8 here as
DEFAULT_MAX_MAPTRACK_FRAMES / DEFAULT_MAX_NR_GRANT_FRAMES
(with a BUILD_BUG_ON() making sure the former isn't smaller than
the latter)?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel