Re: [Xen-devel] [PATCH for-xen-4.5 v4 02/18] x86/boot: fix reloc.S build dependencies

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.10.14 at 16:56, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 17/10/14 15:11, Daniel Kiper wrote:
>> reloc.S is not rebuild if header included
>> in reloc.c is updated. Fix this issue.
>>
>> Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
>> ---
>>  xen/arch/x86/boot/Makefile   |    6 +++++-
>>  xen/arch/x86/boot/build32.mk |    3 ++-
>>  2 files changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/xen/arch/x86/boot/Makefile b/xen/arch/x86/boot/Makefile
>> index 13f4a66..3cab36a 100644
>> --- a/xen/arch/x86/boot/Makefile
>> +++ b/xen/arch/x86/boot/Makefile
>> @@ -1,8 +1,12 @@
>>  obj-bin-y += head.o
>>  
>> +RELOC_DEPS = $(BASEDIR)/include/asm-x86/config.h 
>> $(BASEDIR)/include/xen/multiboot.h
> 
> What is wrong with the normal gcc method of using "-MMD -MF" ?  It would
> avoid duplicating the list of includes in the Makefile.

The main one being that build32.mk doesn't get invoked with the
full build machinery in place, but just via "$(MAKE) -f".

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel