Re: [Xen-devel] [PATCH v6 6/8] xen/arm: introduce GNTTABOP_cache_flush

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.10.14 at 16:45, <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> @@ -2953,6 +3086,10 @@ static int __init gnttab_usage_init(void)
>      if ( !max_maptrack_frames )
>          max_maptrack_frames = MAX_MAPTRACK_TO_GRANTS_RATIO * 
> max_grant_frames;
>  
> +    if ( max_grant_frames > DEFAULT_MAX_NR_GRANT_FRAMES )
> +        printk(XENLOG_WARNING "An high gnttab_max_frames can seriously slow 
> down the hypervisor.\n"
> +                "It is recommended to set gnttab_max_frames to %d max.\n", 
> DEFAULT_MAX_NR_GRANT_FRAMES);

It is certainly odd for the default being the maximum, but okay - if
others consider this fine, I'm not going to object.

Also, again - long lines. And the message should start with "A high"
I think, while the second line of the message needs another
XENLOG_WARNING prefixed.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel