Re: [Xen-devel] [PATCH v3 for 4.5] arm32: fix build after 063188f4b3

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2014-10-14 at 17:32 +0100, Julien Grall wrote:
> @@ -263,7 +250,7 @@ static int exynos5_cpu_up(int cpu)
>      iounmap(power);
>  
>      if ( secure_firmware )
> -        exynos_smc(SMC_CMD_CPU1BOOT, cpu, 0, 0);
> +        call_smc1(SMC_CMD_CPU1BOOT, cpu);
>  

Have you confirmed that none of these zeroes (throughout the patch, not
just here) are actually unused and not just formal parameters which
happen to be zero.

For example:

> -    return __invoke_psci_fn_smc(psci_cpu_on_nr,
> -                                cpu_logical_map(cpu), __pa(init_secondary), 
> 0);
> +    return call_smc2(psci_cpu_on_nr, cpu_logical_map(cpu), 
> __pa(init_secondary));

CPU_ON takes three arguments, target_cpu, entry_point_address and
context_id, so the zero here is actually the context_id parameter and
not a dummy argument.

> +#elif defined(CONFIG_ARM_64)
> +/* Not specific ARM64 macros for now */

"No specific..."

> +
> +int do_smc(register_t function_id, ...);

Stray?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel