Re: [Xen-devel] [PATCH v2 for 4.5] arm32: fix build after 063188f4b3

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Jan,

On 10/13/2014 04:49 PM, Jan Beulich wrote:
>>>> On 13.10.14 at 17:29, <julien.grall@xxxxxxxxxx> wrote:
>> "xen: arm: Add support for the Exynos secure firmware" introduced code
>> assuming that exynos_smc() would get called with arguments in certain
>> registers. While the "noinline" attribute guarantees the function to
>> not get inlined, it does not guarantee that all arguments arrive in the
>> assumed registers: gcc's interprocedural analysis can result in clone
>> functions to be created where some of the incoming arguments (commonly
>> when they have constant values) get replaced by putting in place the
>> respective values inside the clone.
>>
>> Xen contains in multiple place of this SMC function: consolidate the 
>> function
>> in a single place and write it in assembly.
>>
>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>
>> ---
>> This is a fix for Xen 4.5 to compile the hypervisor with GCC 4.9.1, used by
>> Fedora & co.
>>
>> Jan: I kept your Signed-off-by for the commit message.
> 
> I don't think you should have - nothing of my original fix got retained
> afaict. IMO you should convert this to a Reported-by.

I wasn't sure if Signed-off-by was required when copying the commit
message. I will replace the Signed-off-by by Reported-by.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel