Re: [Xen-devel] [RFC][PATCH v2 1/1] Add IOREQ_TYPE_VMWARE_PORT

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.10.14 at 21:51, <dslutz@xxxxxxxxxxx> wrote:
> On 10/06/14 05:39, Jan Beulich wrote:
>> I'm fine with the union approach (subject to convincing myself that
>> all this effort and new code is really worth it in the first place, as
>> said elsewhere before), just not as part of the public interface
>> (unless there is a clear need for it to be there).
> 
> I am read this as yes, add the union_ioreq_t to Xen but not to QEMU.

Not exactly: Since the union approach is mechanism, not interface,
both Xen and any consumer of the public interface can choose to
follow this route or use (fragile) casts.

> I know of at least 1 custom kernel that requires the VMware "rpc" code.
> So I think that vmware_port support is just like viridian support. It allows
> more guests to be run under Xen.

Not exactly: You're adding much more code than Viridian support
has accumulated over several years, and quite a bit of that based
on observation rather than a publicly available spec.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel