Re: [Xen-devel] [RFC][PATCH v2 1/1] Add IOREQ_TYPE_VMWARE_PORT

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.10.14 at 21:27, <dslutz@xxxxxxxxxxx> wrote:
> --- a/xen/include/public/hvm/ioreq.h
> +++ b/xen/include/public/hvm/ioreq.h
> @@ -85,11 +85,22 @@ struct vmware_ioreq {
>   };
>   typedef struct vmware_ioreq vmware_ioreq_t;
> 
> +union union_ioreq {
> +    ioreq_t oreq;
> +    vmware_ioreq_t vreq;
> +};
> +typedef union union_ioreq union_ioreq_t;
> +
>   struct shared_iopage {
>       struct ioreq vcpu_ioreq[1];
>   };
>   typedef struct shared_iopage shared_iopage_t;
> 
> +struct union_shared_iopage {
> +    union union_ioreq vcpu_ioreq[1];
> +};
> +typedef struct union_shared_iopage union_shared_iopage_t;

I don't think either of these really need to be part of the public
interface. (That said, I'm far from being convinced of this
overloading mechanism, and in fact much of this VMware support
code, in the first place.) 

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel