[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 2/4] xen: introduce grant_map_exists
>>> On 06.10.14 at 11:41, <stefano.stabellini@xxxxxxxxxxxxx> wrote: > On Mon, 6 Oct 2014, Jan Beulich wrote: >> >>> On 03.10.14 at 16:50, <stefano.stabellini@xxxxxxxxxxxxx> wrote: >> > --- a/xen/common/grant_table.c >> > +++ b/xen/common/grant_table.c >> > @@ -484,6 +484,36 @@ static int _set_status(unsigned gt_version, >> > return _set_status_v2(domid, readonly, mapflag, shah, act, > status); >> > } >> > >> > +static bool_t grant_map_exists(struct domain *ld, >> > + struct grant_table *rgt, >> >> Please constify these if possible. > > rgt is used below as argument for 2 functions that take non-const struct > grant_table *. nr_grant_entries() could certainly be dealt with, but I guess the other is the spin_is_locked() that the current version wrongly omitted. In which case yes, this needs to be kept non-const. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |