[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/2] xen/arm: Use PSCI-0.2 for machine_halt/restart by default





On 10/02/2014 04:50 PM, Julien Grall wrote:


On 02/10/2014 20:51, Suravee Suthikulpanit wrote:


On 10/02/2014 05:54 AM, Julien Grall wrote:
Hi Suravee,

On 10/01/2014 09:02 PM, suravee.suthikulpanit@xxxxxxx wrote:
  void machine_halt(void)
  {
+    int timeout = 10;
+
      watchdog_disable();
      console_start_sync();
      local_irq_enable();
      smp_call_function(halt_this_cpu, NULL, 0);
+    local_irq_disable();
+
+    /* Wait at most another 10ms for all other CPUs to go offline. */
+    while ( (num_online_cpus() > 1) && (timeout-- > 0) )
+        mdelay(1);
+

This doesn't look like PSCI specific. Can you explain in the commit
message why you need to add this new block of code?

Regards,


It's not PSCI specific. I was just trying to handle the graceful
shutdown similar to the code flow in machine_restart. If you think it's
not necessary, I can take this out.

I'm fine with keeping this code in the patch. I was requesting to
specify in the commit message that you are adding this code for...

Regards,



Ok, I'll resend w/ the update commit message.

Thanks,

Suravee

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.