Re: [Xen-devel] [PATCH] x86/APIC: don't make wrong implications on constants

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 01/10/14 09:31, Jan Beulich wrote:
>>>> On 01.10.14 at 10:15, <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 01/10/14 08:30, Jan Beulich wrote:
>>> For the physical APIC oprofile code was abusing APIC_DM_NMI as a mask.
>> I think you need a comma after APIC for this sentence to parse correctly.
> I had one there and the dropped it. I'm never really sure about the
> punctuation differences between German and English.
>
>>> For the virtual APIC a wrong assumption was made that LVTPC could be
> Wouldn't a comma then be needed after APIC here too?

Strictly speaking yes (and I thought so just after sending the email),
but "a wrong assumption" changes the structure sufficiently that it
isn't anything like as obvious.

~Andrew


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel