Re: [Xen-devel] [PATCH] x86/APIC: don't make wrong implications on constants

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.10.14 at 10:15, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 01/10/14 08:30, Jan Beulich wrote:
>> For the physical APIC oprofile code was abusing APIC_DM_NMI as a mask.
> 
> I think you need a comma after APIC for this sentence to parse correctly.

I had one there and the dropped it. I'm never really sure about the
punctuation differences between German and English.

>> For the virtual APIC a wrong assumption was made that LVTPC could be

Wouldn't a comma then be needed after APIC here too?

>> programmed to only fixed or NMI delivery modes. While other modes are
>> invalid here, we still shouldn't inject an NMI into the guest in such
>> a case. Instead just do nothing.
>>
>> In the course of adjusting this it became obvious that what value
>> vpmu_do_interrupt() returns on its various return paths was pretty
>> arbitrary. With its only caller ignoring the return value, simply make
>> the function's return type "void".
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Content wise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Thanks, Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel