[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/xen-scsiback: Need go to fail after xenbus_dev_error()



On 9/29/14 21:57, David Vrabel wrote:
> On 29/09/14 10:59, Chen Gang wrote:
>>
>>
>> If no any additional reply within 2 days, I shall send patch v2 for it:
>>
>>   "use dev_warn() instead of xenbus_dev_error() and remove 'fail' code block"
> 
> I think this driver is fine as-is and does not need any changes.
> 

OK, at least, at present, it is not a bug (will cause any issue).

But for me, xenbus_dev_error() seems for printing generic errors,
dev_warn() is more suitable than it.

And 'fail' code block is useless now, need be removed, too (which will
let compiler report warning).


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.