[Xen-devel] [PATCH] xen/xen-scsiback: Need go to fail after xenbus_dev_error()

[Chen Gang <gang.chen.5i5j@xxxxxxxxx>]

When failure occurs, after xenbus_dev_error(), need go to fail to let
upper caller know about it.

Signed-off-by: Chen Gang <gang.chen.5i5j@xxxxxxxxx>
---
 drivers/xen/xen-scsiback.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c
index 847bc9c..3e430e1 100644
--- a/drivers/xen/xen-scsiback.c
+++ b/drivers/xen/xen-scsiback.c
@@ -1222,8 +1222,10 @@ static int scsiback_probe(struct xenbus_device *dev,
 
        err = xenbus_printf(XBT_NIL, dev->nodename, "feature-sg-grant", "%u",
                            SG_ALL);
-       if (err)
+       if (err) {
                xenbus_dev_error(dev, err, "writing feature-sg-grant");
+               goto fail;
+       }
 
        xenbus_switch_state(dev, XenbusStateInitWait);
        return 0;
-- 
1.9.3

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel