Re: [Xen-devel] [PATCH for-4.5 v11 1/9] xen/arm: p2m changes for mem_access support

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Mon, Sep 29, 2014 at 2:26 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:

Hi Tamas,

On 09/29/2014 12:36 PM, Tamas K Lengyel wrote:
>  unsigned long gmfn_to_mfn(struct domain *d, unsigned long gpfn)
> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
> index 787e93c..3d69152 100644
> --- a/xen/include/asm-arm/domain.h
> +++ b/xen/include/asm-arm/domain.h
> @@ -17,6 +17,7 @@ struct hvm_domain
>  {
>      uint64_t              params[HVM_NR_PARAMS];
>      struct hvm_iommu      iommu;
> +    bool_t                introspection_enabled;

Sorry, I haven't catch it before...

This field is used by the common code, can't it be moved in
xen/domain.h? Maybe protected by an #ifdef.

Do you mean struct domain in xen/sched.h? That could be done I suppose. I was debating if rather then including this field in the ARM struct to just have an empty p2m inline function for ARM that is called from the common code. IMHO that would be preferred if including this field as it is now is no good.

Tamas

 

I'm fine, if the code movement is done in a follow-up patch. So:

Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel