Re: [Xen-devel] [PATCH for-4.5 v11 1/9] xen/arm: p2m changes for mem_access support

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Tamas,

On 09/29/2014 12:36 PM, Tamas K Lengyel wrote:
>  unsigned long gmfn_to_mfn(struct domain *d, unsigned long gpfn)
> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
> index 787e93c..3d69152 100644
> --- a/xen/include/asm-arm/domain.h
> +++ b/xen/include/asm-arm/domain.h
> @@ -17,6 +17,7 @@ struct hvm_domain
>  {
>      uint64_t              params[HVM_NR_PARAMS];
>      struct hvm_iommu      iommu;
> +    bool_t                introspection_enabled;

Sorry, I haven't catch it before...

This field is used by the common code, can't it be moved in
xen/domain.h? Maybe protected by an #ifdef.

I'm fine, if the code movement is done in a follow-up patch. So:

Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel