Re: [Xen-devel] [PATCH V5 02/15] Move x86 specific funtions/variables to arch header

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.09.14 at 04:35, <roy.franz@xxxxxxxxxx> wrote:
> On Tue, Sep 23, 2014 at 5:24 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>>> On 23.09.14 at 04:08, <roy.franz@xxxxxxxxxx> wrote:
>>> extern l4_pgentry_t *efi_l4_pgtable;
>>> maybe should be moved back to boot.c for now, but this is an x86
>>> specific structure that is only referenced there due to the
>>> runtime code being #ifdef'ed out.
>>
>> It's currently being declared in xen/arch/x86/efi/efi.h, and I
>> can't really see why this isn't sufficient.
> 
> xen/arch/x86/efi/efi.h is a link to common/efi/efi.h, so it is a shared
> header.  I could put it there with #ifdef, or leave it the the architecture
> specific header file.

Following the as-private-as-possible model going the #ifdef route
seems better to me even if resulting in slightly more ugly code.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel