Re: [Xen-devel] [PATCH v4 1/4] x86/HVM: fix miscellaneous aspects of x2APIC emulation

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.09.14 at 18:56, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 22/09/14 14:40, Jan Beulich wrote:
>>>>> On 22.09.14 at 15:14, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> On 18/09/14 15:43, Jan Beulich wrote:
>>>> @@ -891,16 +876,33 @@ int hvm_x2apic_msr_write(struct vcpu *v,
>>>>  
>>>>      switch ( offset )
>>>>      {
>>>> -        int rc;
>>>> +    case APIC_TASKPRI:
>>>> +    case APIC_EOI:
>>>> +    case APIC_SPIV:
>>>> +    case APIC_CMCI:
>>>> +    case APIC_LVTT ... APIC_LVTERR:
>>>> +    case APIC_TMICT:
>>>> +    case APIC_TMCCT:
>>>> +    case APIC_TDCR:
>>> Most (all?) of these MSRs have reserved bits, which should fail with a
>>> #GP(0) for attempts to set. vlapic_reg_read() masks most of the relevant
>>> bits, but doesn't appear to hit a misbehaving VM.
>> Perhaps, but not in this patch.
> 
> Does it not count towards fixing misc aspects of x2APIC emulation?

Sure it does - I guess I should go and see by how much it grows
the patch (I really don't want it to double its size because of this).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel