Re: [Xen-devel] [PATCH for-4.5 v11 2/7] xen/arm: Add vgic callback to read irq priority

[Vijay Kilari <vijay.kilari@xxxxxxxxx>]

On Tue, Sep 23, 2014 at 6:31 PM, Stefano Stabellini
<stefano.stabellini@xxxxxxxxxxxxx> wrote:
>> >> > priority = vgic_byte_read(rank->ipriority[REG_RANK_INDEX(8, irq,
>> >> >             DABT_WORD)], 0, irq & 0x3);
>> >> >
>> >> > It is best to use the previous version, as it uses the common conversion
>> >> > functions.
>> >>
>> >>  I changed it because we don't need do clumsy things
>> >> to get ipriority index with irq number in hand. If you don't
>> >> have any further comments, I will send final version with this change
>> >> for your ack.
>> >
>> > TBH I think that the open coded version is more readable than the macro,
>> > but we need to be consistent (so that we can easily change the macro and
>> > fix all the call sites in one change for example).
>> >
>> > In any case I don't think that you need to resend just for this small
>> > change. We can fix in a follow up patch.
>>
>>  I see that you have made similar changes using in vgic-v2.c in
>>
>>  static struct vcpu *vgic_v2_get_target_vcpu(struct vcpu *v, unsigned int 
>> irq)
>>  {
>> ....
>>      target = vgic_byte_read(rank->itargets[(irq%32)/4], 0, irq % 4);
>
> Ops, I see that I talk the talk but I don't walk the walk
>
>
>> shall I revert back to use REG_RANK_INDEX here as well in my next
>> commit?
>
> Yes, please

I have already sent patch by name "xen/arm: Use REG_RANK_INDEX macro"
Please review

Regards
Vijay

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel