Re: [Xen-devel] [PATCH 42/46] Use XEN_RUN_DIR instead of /var/run/xen

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-09-23 at 15:01 +0200, Olaf Hering wrote:
> On Tue, Sep 23, Ian Campbell wrote:
> 
> > On Mon, 2014-09-22 at 15:00 +0200, Olaf Hering wrote:
> > > Also remove duplicate XEN_RUN_DIR from m4/paths.m4.
> > > Fix XEN_RUN_DIR expansion in toplevel Makefile
> > > 
> > > Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> > > ---
> > >  Makefile                                                          | 2 +-
> > >  m4/paths.m4                                                       | 3 ---
> > >  tools/hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service.in | 2 +-
> > >  3 files changed, 2 insertions(+), 5 deletions(-)
> > > 
> > > diff --git a/Makefile b/Makefile
> > > index 7558262..b0742cf 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -221,7 +221,7 @@ uninstall:
> > >   rm -f  $(D)$(XEN_SYSTEMD_DIR)/*.service
> > >   rm -f  $(D)$(XEN_SYSTEMD_DIR)/*.mount
> > >   rm -f  $(D)$(XEN_SYSTEMD_MODULES_LOAD)/*.conf
> > > - rm -rf $(D)$(XEN_RUN_DIR)* $(D)/var/lib/xen*
> > > + rm -rf $(D)$(XEN_RUN_DIR)/* $(D)/var/lib/xen*
> > 
> > This would previous have removed XEN_RUN_DIR itself and not just the
> > contents. It would also have historically also cleaned up
> > $(XEN_RUN_DIR)d (i.e. xend...)!
> > 
> > Perhaps just add an rmdir to follow this, globbing the dir is indeed
> > pretty skanky (and probably annoies e.g. the xenomai maintainers!)
> 
> The uninstall target is indeed special. It leaves half of the make
> install result on the system. And the globbing needs more work.

To say the least.

> I will address this in the next version of the patch.

Just the wrinkle above? Feel free to ignore the larger Yakk for the time
bein ;-)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel