Re: [Xen-devel] [PATCH 03/46] install.sh: Preserve permissions from make install

[Olaf Hering <olaf@xxxxxxxxx>]

On Mon, Sep 22, Ian Campbell wrote:

> On Mon, 2014-09-22 at 14:59 +0200, Olaf Hering wrote:
> Although, do you suppose that the tar unpack right above it ought to use
> -p/--preserve-permissions ?

At least the tar I use preserves permissions automatically.
I wonder what the removed chmod tried to fix anyway.

Olaf

> > +++ b/install.sh
> > @@ -27,9 +27,6 @@ tmp="`mktemp -d`"
> >  echo "Installing Xen from '$src' to '$dst'..."
> >  (cd $src; tar -cf - * ) | tar -C "$tmp" -xf -
> >  
> > -echo " - modifying permissions"
> > -chmod -R a+rX "$tmp"
> > -
> >  (cd $tmp; tar -cf - *) | tar --no-same-owner -C "$dst" -xf -
> >  rm -rf "$tmp"
> >  
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel