Re: [Xen-devel] [PATCH 03/46] install.sh: Preserve permissions from make install

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-09-22 at 14:59 +0200, Olaf Hering wrote:
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

I wonder what this will break. Only one way to find out:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Although, do you suppose that the tar unpack right above it ought to use
-p/--preserve-permissions ?

> ---
>  install.sh | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/install.sh b/install.sh
> index 272123a..3e11c4d 100644
> --- a/install.sh
> +++ b/install.sh
> @@ -27,9 +27,6 @@ tmp="`mktemp -d`"
>  echo "Installing Xen from '$src' to '$dst'..."
>  (cd $src; tar -cf - * ) | tar -C "$tmp" -xf -
>  
> -echo " - modifying permissions"
> -chmod -R a+rX "$tmp"
> -
>  (cd $tmp; tar -cf - *) | tar --no-same-owner -C "$dst" -xf -
>  rm -rf "$tmp"
>  



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel