Re: [Xen-devel] [RFC Patch v4 7/9] correct xc_domain_save()'s return value

[Wen Congyang <wency@xxxxxxxxxxxxxx>]

On 09/22/2014 04:13 PM, Olaf Hering wrote:
> On Mon, Sep 22, Wen Congyang wrote:
> 
>> The callbacks may be implemented in libxl, which is another process.
>> xc_domain_save() is a public API, and the caller may forget to set
>> the errno...
>>
>> So we cannot assume that the callbacks has set the errno
> 
> Then the caller is using xc_domain_save incorrectly.
> Looks like there is no API documentation, other than the source code.

Yes, we should allow that the caller uses xc_domain_save() incorrectly, and
xc_domain_save() should return 1 not 0 in this case.

Thanks
Wen Congyang

> 
> Olaf
> .
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel