Re: [Xen-devel] [v6][PATCH 7/7] xen/vtd: make USB RMRR mapping safe

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.09.14 at 07:49, <tiejun.chen@xxxxxxxxx> wrote:
> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -2273,16 +2273,8 @@ static int intel_iommu_assign_device(
>      if ( ret )
>          goto done;
>  
> -    /* FIXME: Because USB RMRR conflicts with guest bios region,
> -     * ignore USB RMRR temporarily.
> -     */
>      seg = pdev->seg;
>      bus = pdev->bus;
> -    if ( is_usb_device(seg, bus, pdev->devfn) )
> -    {
> -        ret = 0;
> -        goto done;
> -    }
>  
>      /* Setup rmrr identity mapping */
>      for_each_rmrr_device( rmrr, bdf, i )

This orphans is_usb_device(), which therefore the patch should
remove at once.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel