Re: [Xen-devel] [v6][PATCH 2/7] tools/libxc: introduce hypercall for xc_reserved_device_memory_map

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-09-11 at 16:21 +0100, Jan Beulich wrote:
> >>> On 10.09.14 at 07:49, <tiejun.chen@xxxxxxxxx> wrote:
> > +    if ( errno == ENOBUFS )
> > +        *max_entries = memmap.nr_entries;
> > +
> > +    return rc ? -errno : memmap.nr_entries;
> > +}
> 
> Isn't libxc generally aiming at using POSIX style return values, i.e. -1
> one error with errno indicating the details?

We are trying to move that way, yes. It's an unholy mess right now but
lets at least try not to add to it!

>  Furthermore you're even
> inconsistent with yourself, as you return -1 in an earlier error path.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel