Re: [Xen-devel] [v6][PATCH 2/7] tools/libxc: introduce hypercall for xc_reserved_device_memory_map

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.09.14 at 07:49, <tiejun.chen@xxxxxxxxx> wrote:
> +    if ( errno == ENOBUFS )
> +        *max_entries = memmap.nr_entries;
> +
> +    return rc ? -errno : memmap.nr_entries;
> +}

Isn't libxc generally aiming at using POSIX style return values, i.e. -1
one error with errno indicating the details? Furthermore you're even
inconsistent with yourself, as you return -1 in an earlier error path.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel