Re: [Xen-devel] [PATCH v12 10/14] xsm/flask: avoid spurious error messages when mapping I/O-memory

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-09-03 at 12:22 +0100, Ian Campbell wrote:
> On Sat, 2014-08-30 at 18:29 +0200, Arianna Avanzini wrote:
> > Currently, FLASK only handles the memory_mapping hypercall for the
> > x86 architecture. In case the architecture is ARM, an error message
> > will be printed regardless of how XSM has been configured. This
> > commit lets the memory_mapping case be handled also for architectures
> > other than x86.
> > 
> > Signed-off-by: Arianna Avanzini <avanzini.arianna@xxxxxxxxx>
> > Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>
> > Cc: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> > Cc: Paolo Valente <paolo.valente@xxxxxxxxxx>
> > Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> 
> Acked-by: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>

Although since patches further down the series require a resend I'm also
going to ask that you rephrase the commit message in terms of what it
does "Handle XEN_DOMCTL_memory_mapping for all architectures" rather
than its side effect (removing an error message). With some sort of
change along those lines you may keep the acked by.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel