Re: [Xen-devel] [PATCH v12 10/14] xsm/flask: avoid spurious error messages when mapping I/O-memory

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Sat, 2014-08-30 at 18:29 +0200, Arianna Avanzini wrote:
> Currently, FLASK only handles the memory_mapping hypercall for the
> x86 architecture. In case the architecture is ARM, an error message
> will be printed regardless of how XSM has been configured. This
> commit lets the memory_mapping case be handled also for architectures
> other than x86.
> 
> Signed-off-by: Arianna Avanzini <avanzini.arianna@xxxxxxxxx>
> Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>
> Cc: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> Cc: Paolo Valente <paolo.valente@xxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>

> Cc: Jan Beulich <JBeulich@xxxxxxxx>
> Cc: Keir Fraser <keir@xxxxxxx>
> Cc: Tim Deegan <tim@xxxxxxx>
> Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Cc: Eric Trudeau <etrudeau@xxxxxxxxxxxx>
> Cc: Viktor Kleinik <viktor.kleinik@xxxxxxxxxxxxxxx>
> Cc: Andrii Tseglytskyi <andrii.tseglytskyi@xxxxxxxxxxxxxxx>
> ---
>  xen/xsm/flask/hooks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
> index f2f59ea..a0e4ae0 100644
> --- a/xen/xsm/flask/hooks.c
> +++ b/xen/xsm/flask/hooks.c
> @@ -570,6 +570,7 @@ static int flask_domctl(struct domain *d, int cmd)
>      case XEN_DOMCTL_scheduler_op:
>      case XEN_DOMCTL_irq_permission:
>      case XEN_DOMCTL_iomem_permission:
> +    case XEN_DOMCTL_memory_mapping:
>      case XEN_DOMCTL_set_target:
>  #ifdef CONFIG_X86
>      /* These have individual XSM hooks (arch/x86/domctl.c) */
> @@ -577,7 +578,6 @@ static int flask_domctl(struct domain *d, int cmd)
>      case XEN_DOMCTL_ioport_permission:
>      case XEN_DOMCTL_bind_pt_irq:
>      case XEN_DOMCTL_unbind_pt_irq:
> -    case XEN_DOMCTL_memory_mapping:
>      case XEN_DOMCTL_ioport_mapping:
>      case XEN_DOMCTL_mem_event_op:
>      /* These have individual XSM hooks (drivers/passthrough/iommu.c) */



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel