Re: [Xen-devel] [PATCH v3 03/15] xen: Relocate mem_event_op domctl and access_op memop into common.

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Tue, Sep 2, 2014 at 8:53 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:

>>> On 01.09.14 at 22:51, <tamas.lengyel@xxxxxxxxxxxx> wrote:
> On Mon, Sep 1, 2014 at 8:11 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:

>> On 01/09/14 10:21, Tamas K Lengyel wrote:
>> > diff --git a/xen/common/memory.c b/xen/common/memory.c
>> > index cc8a3d0..4e530bf 100644
>> > --- a/xen/common/memory.c
>> > +++ b/xen/common/memory.c
>> > @@ -25,6 +25,7 @@
>> >   #include <asm/hardirq.h>
>> >   #include <asm/p2m.h>
>> >   #include <xen/numa.h>
>> > +#include <xen/mem_access.h>
>> >   #include <public/memory.h>
>>
>
> @Julien: the problem causing your compile issue is here with the order of
> the inclusion of the headers. public/memory.h needs to be included before
> xen/mem_access.h, I'll fix it in the next iteration..

But then please by making xen/mem_access.h include the prereq
header rather than altering the order here.

Jan

I was thinking of the same thing, that would be a lot more robust solution.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel