Xen project Mailing List

Re: [Xen-devel] [PATCH v3 03/15] xen: Relocate mem_event_op domctl and access_op memop into common.

On Mon, Sep 1, 2014 at 8:11 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:

Hello Tamas,

On 01/09/14 10:21, Tamas K Lengyel wrote:
> diff --git a/xen/common/memory.c b/xen/common/memory.c
> index cc8a3d0..4e530bf 100644
> --- a/xen/common/memory.c
> +++ b/xen/common/memory.c
> @@ -25,6 +25,7 @@
> #include <asm/hardirq.h>
> #include <asm/p2m.h>
> #include <xen/numa.h>
> +#include <xen/mem_access.h>
> #include <public/memory.h>

@Julien: the problem causing your compile issue is here with the order of the inclusion of the headers. public/memory.h needs to be included before xen/mem_access.h, I'll fix it in the next iteration..

> #include <xsm/xsm.h>
> #include <xen/trace.h>
> @@ -969,6 +970,10 @@ long do_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>
> break;
>
> + case XENMEM_access_op:
> + rc = mem_access_memop(cmd, guest_handle_cast(arg, xen_mem_access_op_t));
> + break;
> +

Every patch should be able to compile without requiring a future patch.
This is very useful when we need to bisect the tree.

Actually I got the following error:

In file included from /home/julieng/works/xen/xen/include/asm/system.h:6:0,
from /home/julieng/works/xen/xen/include/xen/list.h:11,
from /home/julieng/works/xen/xen/include/xen/mm.h:32,
from memory.c:13:
/home/julieng/works/xen/xen/include/public/arch-arm.h:196:41: error: unknown type name ‘__guest_handle_xen_mem_access_op_t’
#define XEN_GUEST_HANDLE_PARAM(name) __guest_handle_ ## name
^
/home/julieng/works/xen/xen/include/xen/mem_access.h:36:22: note: in expansion of macro ‘XEN_GUEST_HANDLE_PARAM’
XEN_GUEST_HANDLE_PARAM(xen_mem_access_op_t) arg)
^
memory.c: In function ‘do_memory_op’:
memory.c:974:9: error: implicit declaration of function ‘mem_access_memop’ [-Werror=implicit-function-declaration]

rc = mem_access_memop(cmd, guest_handle_cast(arg, xen_mem_access_op_t));

^
memory.c:974:9: error: nested extern declaration of ‘mem_access_memop’ [-Werror=nested-externs]

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

_______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel