Re: [Xen-devel] [PATCH v6 10/10] libxl: set vnuma for domain

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On mar, 2014-08-12 at 10:42 +0100, Wei Liu wrote:
> On Mon, Aug 11, 2014 at 11:52:55PM -0400, Elena Ufimtseva wrote:

> > Preparing the series, I figured that this particular function
> > libxl_domain_setvnuma does not have any users. Instead, xc one is
> > called directly.
> > I want to omit this patch. Do I need to have  #define
> > LIBXL_HAVE_DOMAIN_SETVNUMA 1 in this case?
> > 
> 
> If your macro is specifically for this function then you need to remove
> macro as well. In this case I think the answer is "no you don't need
> that in libxl.h", unless I've mistaken the purpose of your macro.
> 
> Wei.

It was something you (Wei) suggested. :-P :-P :-P

(Cutting and pasting from
http://bugs.xenproject.org/xen/mid/%3C20140718105838.GE7142@xxxxxxxxxxxxxxxxxxxxx%3E
 )
---
>  int libxl_fd_set_cloexec(libxl_ctx *ctx, int fd, int cloexec);
>  int libxl_fd_set_nonblock(libxl_ctx *ctx, int fd, int nonblock);
>  
> +int libxl_domain_setvnuma(libxl_ctx *ctx,
> +                           uint32_t domid,
> +                           uint16_t nr_vnodes,
> +                           uint16_t nr_vcpus,
> +                           vmemrange_t *vmemrange,
> +                           unsigned int *vdistance,
> +                           unsigned int *vcpu_to_vnode,
> +                           unsigned int *vnode_to_pnode);
> +
>  #include <libxl_event.h>
>  

You will need to add
  #define LIBXL_HAVE_DOMAIN_SETVNUMA 1
to advertise the introduction of new API.

Wei.
---

Anyway, I agree: if the function goes, no need to add any macro.

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel