[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/1] xen:include:asm-x86:e820: just covert nr_map with unsigned int

To: "Tiejun Chen" <tiejun.chen@xxxxxxxxx>
From: "Jan Beulich" <JBeulich@xxxxxxxx>
Date: Fri, 08 Aug 2014 08:15:23 +0100
Cc: keir@xxxxxxx, xen-devel@xxxxxxxxxxxxx
Delivery-date: Fri, 08 Aug 2014 07:15:39 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

>>> On 08.08.14 at 09:00, <tiejun.chen@xxxxxxxxx> wrote:
> This shouldn't ever be negative.

This means nothing for the actual change, and makes me imply you did
the change without checking it actually _is_ never negative in any of
the uses.

Also please cut down your patch title prefixes (not just here) to
something reasonable.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

Follow-Ups:
- Re: [Xen-devel] [PATCH 1/1] xen:include:asm-x86:e820: just covert nr_map with unsigned int
  - From: Chen, Tiejun

Prev by Date: Re: [Xen-devel] [Xen-unstable] XenbusState signaling with regard to pci-detach on HVM guests
Next by Date: Re: [Xen-devel] [RFC Patch v2 00/45] COarse-grain LOck-stepping Virtual Machines for Non-stop Service
Previous by thread: [Xen-devel] [RFC Patch v2 00/45] COarse-grain LOck-stepping Virtual Machines for Non-stop Service
Next by thread: Re: [Xen-devel] [PATCH 1/1] xen:include:asm-x86:e820: just covert nr_map with unsigned int
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.