Re: [Xen-devel] [PATCH 3/3] x86/HVM: command line option adjustments

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

> From: Boris Ostrovsky [mailto:boris.ostrovsky@xxxxxxxxxx]
> Sent: Wednesday, July 30, 2014 9:56 AM
> 
> On 07/30/2014 12:09 PM, Jan Beulich wrote:
> >
> > --- a/xen/arch/x86/hvm/hvm.c
> > +++ b/xen/arch/x86/hvm/hvm.c
> > @@ -70,8 +70,10 @@
> >
> >   bool_t __read_mostly hvm_enabled;
> >
> > +#ifdef DBG_LEVEL_0
> >   unsigned int opt_hvm_debug_level __read_mostly;
> >   integer_param("hvm_debug", opt_hvm_debug_level);
> > +#endif
> 
> 
> Do you think "#ifndef NDEBUG" might be better given that it is what
> defines DBG_LEVEL_0 (and all other DBG_LEVELs)?
> 

Agree.

Thanks
Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel